Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move remaining instrumentation libraries to the opentelemetry-dotnet-contrib repo #5526

Closed
vishweshbankwar opened this issue Apr 9, 2024 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@vishweshbankwar
Copy link
Member

The repo currently maintains the following instrumentation libraries:

  • OpenTelemetry.instrumentation.AspNetCore
  • OpenTelemetry.instrumentation.HttpClient
  • OpenTelemetry.instrumentation.SqlClient
  • OpenTelemetry.instrumentation.GrpcNetClient

We should consider them moving all to the contrib repo and keep this repo focused mainly on core components.

@cijothomas
Copy link
Member

We'll miss some extra test coverage by doing this, but that is okay, since all signals/instrumentations are stable already!

@vishweshbankwar
Copy link
Member Author

@cijothomas - Thats a good point. I think that can be managed by upgrading the dependencies on instrumentation libraries in timely manner.

@vishweshbankwar vishweshbankwar added the help wanted Good for taking. Extra help will be provided by maintainers label Apr 12, 2024
@vishweshbankwar vishweshbankwar removed the help wanted Good for taking. Extra help will be provided by maintainers label Apr 15, 2024
@reyang
Copy link
Member

reyang commented Apr 24, 2024

Also, migrate the existing GitHub issues that are related to these components.

@reyang
Copy link
Member

reyang commented May 13, 2024

I think this is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
4 participants