Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should NegativeBuckets of ExponentialHistogram be made public? #4489

Closed
utpilla opened this issue May 16, 2023 · 1 comment · Fixed by #4494
Closed

Should NegativeBuckets of ExponentialHistogram be made public? #4489

utpilla opened this issue May 16, 2023 · 1 comment · Fixed by #4494
Labels
question Further information is requested

Comments

@utpilla
Copy link
Contributor

utpilla commented May 16, 2023

The spec currently says that Histogram.Record should only be used for non-negative values. However, the spec also mentions how to deal with negative values in case of ExponentialHistograms. The current implementation of ExponentialHistogram does process negative values and puts them into NegativeBuckets.

Do we want to make NegativeBuckets available to exporters considering we should also not expect people to use Histogram.Record for negative values?

@utpilla utpilla added the question Further information is requested label May 16, 2023
@utpilla
Copy link
Contributor Author

utpilla commented May 16, 2023

FYI @alanwest

I spoke to @reyang and it looks like the spec might be updated in the future to allow for negative values in this case. I think we could mark NegativeBuckets internal for now and make it public once the spec changes.

Found a related issue: open-telemetry/opentelemetry-specification#2715

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant