Consider using GetHashCode in TraceIdRatioBasedSampler?

[pbiggar]

I've been looking at a TraceIdRatioSampler, which has some bitwise operations to try and get a ratio from the traceID. It copies the TraceID into a span, then iterates over its lower 8 bits to get an int64.

It seems like calling GetHashCode would have the same probability distribution, and be faster?

[cijothomas]

See this: open-telemetry/opentelemetry-specification#1413

I believe the current implementation is aligned with other languages, though not formally spec-ed, and changes this could have significant impact.

[github-actions]

This issue was marked stale due to lack of activity and will be closed in 7 days. Commenting will instruct the bot to automatically remove the label. This bot runs once per day.

[github-actions]

Closed as inactive. Feel free to reopen if this issue is still a concern.