Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP Server Duration Histogram description does not follow specification #4169

Closed
austinlparker opened this issue Feb 9, 2023 · 1 comment · Fixed by #4171 or open-telemetry/opentelemetry-dotnet-contrib#1063

Comments

@austinlparker
Copy link
Member

Line in question:

this.httpServerDuration = meter.CreateHistogram<double>(HttpServerDurationMetricName, "ms", "measures the duration of the inbound HTTP request");

Spec reference: https://github.com/open-telemetry/opentelemetry-specification/blob/84a5fa3d1ef42caae8f99f1b431504d7cdb9fffe/specification/metrics/semantic_conventions/http-metrics.md?plain=1#L24

This impacts the OpenTelemetry Demo (open-telemetry/opentelemetry-demo#737) as we are emitting this metric from multiple languages. When the description differs between the same metric name, the prometheus exporter on the collector can't merge the points.

@cijothomas
Copy link
Member

Typo. @vishweshbankwar can you fix? (also double check if there are others as well for metrics)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants