Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Span limits have wrong defaults #3962

Closed
Kielek opened this issue Dec 1, 2022 · 0 comments · Fixed by #3978
Closed

Span limits have wrong defaults #3962

Kielek opened this issue Dec 1, 2022 · 0 comments · Fixed by #3978
Labels
bug Something isn't working
Milestone

Comments

@Kielek
Copy link
Contributor

Kielek commented Dec 1, 2022

Bug Report

List of all OpenTelemetry NuGet
packages
and version that you are
using (e.g. OpenTelemetry 1.0.2):

Current main - post 1.4.0-beta.3.

Symptom

image

What is the expected behavior?

What did you expect to see?

Defaults are same as in https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/sdk-environment-variables.md#span-limits

What is the actual behavior?

All of the limits are set to int.MaxValue when SdkLimitOptions return nulls..

Reproduce

Debug OpenTelemetry.Exporter.OpenTelemetryProtocol.Tests.OtlpHttpTraceExportClientTests.NewOtlpHttpTraceExportClient_OtlpExporterOptions_ExporterHasCorrectProperties

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants