Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remote IP Address - NULL reference exception #3276

Closed
barry-tormey-imprivata opened this issue May 12, 2022 · 2 comments · Fixed by #3481
Closed

Remote IP Address - NULL reference exception #3276

barry-tormey-imprivata opened this issue May 12, 2022 · 2 comments · Fixed by #3481
Labels
bug Something isn't working

Comments

@barry-tormey-imprivata
Copy link

Bug Report

OpenTelemetry.Instrumentation.AspNetCore - v1.0.0-rc9.3

Runtime version: net6.0

Symptom

NullReferernceException thrown when HttpContext.Connection.RemoteIpAddress is null due to a .toString() call in HttpInListener.AddGrpcAttributes

What is the expected behavior?

The AttributeNetPeerIp should not be added to the activity when the RemoteIpAddress property is NULL

What is the actual behavior?

Unhandled NullReferenceException

Reproduce

See RemoteIpAddress documentation indicating the property can be null.
@barry-tormey-imprivata barry-tormey-imprivata added the bug Something isn't working label May 12, 2022
@ghost
Copy link

ghost commented May 24, 2022

I will work on this and submit PR later.

@ghost
Copy link

ghost commented Jun 7, 2022

I will work on this and submit PR later.

I will work on this and submit PR later. Since I changed my account and deleted the before one.

@reyang reyang mentioned this issue Jul 24, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@reyang @barry-tormey-imprivata