Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] ResourceDetector should not be tied to tracing #3027

Closed
cijothomas opened this issue Mar 11, 2022 · 2 comments · Fixed by #5188
Closed

[Docs] ResourceDetector should not be tied to tracing #3027

cijothomas opened this issue Mar 11, 2022 · 2 comments · Fixed by #5188
Labels
documentation Documentation related good first issue Good for newcomers

Comments

@cijothomas
Copy link
Member

https://github.com/open-telemetry/opentelemetry-dotnet/tree/main/docs/trace/extending-the-sdk#resource-detector
Resource is not a concept tied to tracing, but the doc is under the tracing section. The issue is opened to track moving Resource to its own section, and have trace/metric/logs link to it.

@cijothomas cijothomas added the documentation Documentation related label Mar 11, 2022
@cartermp
Copy link
Contributor

Could this maybe be closed now that we have a dedicated resource doc here? https://opentelemetry.io/docs/instrumentation/net/resources/

Although the code sample does show tracing, it's not written in a way that ties it intrinsically to tracing.

@cijothomas
Copy link
Member Author

Not really. This is specifically for the docs maintained in this repo.
(We haven't yet reached the desired state of having a single place for docs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation related good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants