You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'd either like to be able to do the same, or have this hard-coded path be configurable.
Describe alternatives you've considered.
I can use the zipkin exporter, but since we've been using Jaeger already, I'd like to stick with it (plus all the other non .net services still use Jaeger).
Additional Context
I'm happy to implement the feature myself, but thought I should open it up for discussion before doing so.
The text was updated successfully, but these errors were encountered:
I think this would make a fine addition @abe545!
Likely will need to add another parameter to the JaegerHttpClient constructor (or a new constructor, or default value parameter) and a field on the class. If omitted, use the existing /api/traces value.
I'll let you propose the PR and make these implementation choices though 😅
Thanks @mic-max! I was on the fence about adding a new option to the options class, or if I should just use the Endpoint that exists on the options - if it doesn't include a path or query, to use the /api/traces. But if it does include one, to just use it as is. The latter might be slightly confusing, so I'll probably add a new option.
One thing that I was also considering is that this behaves differently from the zipkin exporter. That one just takes the configured endpoint as-is. It would be nice for them to have consistent behavior, but just removing the /api/traces from this class seemed like it would cause a lot of headaches for everybody that currently has this working correctly
Feature Request
Is your feature request related to a problem?
In the
JaegerHttpClient
, the path to post is hard-coded to/api/traces
: https://github.com/open-telemetry/opentelemetry-dotnet/blob/main/src/OpenTelemetry.Exporter.Jaeger/Implementation/JaegerHttpClient.cs#L70I'd like to be able to specify this because the way our infrastructure is setup is that the listener is expecting a different path. And it won't collect trace data if that is appended. We're switching from the Jaeger library with OpenTracing, and it worked previously. I see that the zipkin exporter allows you to specify the endpoint directly
Describe the solution you'd like:
I'd either like to be able to do the same, or have this hard-coded path be configurable.
Describe alternatives you've considered.
I can use the zipkin exporter, but since we've been using Jaeger already, I'd like to stick with it (plus all the other non .net services still use Jaeger).
Additional Context
I'm happy to implement the feature myself, but thought I should open it up for discussion before doing so.
The text was updated successfully, but these errors were encountered: