Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reenable public API check #2526

Closed
cijothomas opened this issue Oct 27, 2021 · 1 comment · Fixed by #2597
Closed

Reenable public API check #2526

cijothomas opened this issue Oct 27, 2021 · 1 comment · Fixed by #2597
Labels
good first issue Good for newcomers help wanted Good for taking. Extra help will be provided by maintainers metrics Metrics signal related

Comments

@cijothomas
Copy link
Member

Was disabled temporarily while Metric was in very early stage. We need to re-enable it and document the public API for metrics
https://github.com/open-telemetry/opentelemetry-dotnet/blob/main/build/Common.prod.props#L11-L15
@cijothomas cijothomas added good first issue Good for newcomers metrics Metrics signal related release:required-for-ga help wanted Good for taking. Extra help will be provided by maintainers labels Oct 27, 2021
@alanwest alanwest assigned alanwest and unassigned alanwest Nov 11, 2021
@cijothomas
Copy link
Member Author

@vishweshbankwar is working on this.

@vishweshbankwar vishweshbankwar mentioned this issue Nov 12, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Good for taking. Extra help will be provided by maintainers metrics Metrics signal related
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Re-enable public api check vishweshbankwar/opentelemetry-dotnet
2 participants
@alanwest @cijothomas