Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run benchmark tests for using activity.CustomProperty vs activity.TagObjects to keep track of activity created by ASP.NET and ASP.NET Core instrumentations #1887

Closed
utpilla opened this issue Mar 9, 2021 · 2 comments
Labels
enhancement New feature or request Stale Issues and pull requests which have been flagged for closing due to inactivity

Comments

@utpilla
Copy link
Contributor

utpilla commented Mar 9, 2021

We need to run benchmark tests to ensure that we are using the most performant approach to keep track of whether the activity in the listener is created by instrumentation or not.

ASP.NET / ASP.NET Core instrumentations create a new activity in the OnStartActivity method and use activity.CustomProperty to keep track of it. The CustomProperty is later looked up in the OnStopActivity method of the listener to stop the activity.

This could also be achieved using Tags instead of CustomProperties. We need to run benchmark tests to know which is the more performant approach.

Copy link
Contributor

This issue was marked stale due to lack of activity and will be closed in 7 days. Commenting will instruct the bot to automatically remove the label. This bot runs once per day.

@github-actions github-actions bot added the Stale Issues and pull requests which have been flagged for closing due to inactivity label Aug 16, 2024
@vishweshbankwar
Copy link
Member

We switched to SetTag(not able to find the PR, assuming it was done after running benchmark). Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Stale Issues and pull requests which have been flagged for closing due to inactivity
Projects
None yet
Development

No branches or pull requests

2 participants