Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTP Span Attributes: http.url must not contain username / password #1884

Closed
pellared opened this issue Mar 9, 2021 · 0 comments · Fixed by #1961
Closed

HTTP Span Attributes: http.url must not contain username / password #1884

pellared opened this issue Mar 9, 2021 · 0 comments · Fixed by #1961
Assignees
@pellared
Labels
enhancement New feature or request

Comments

@pellared
Copy link
Member

pellared commented Mar 9, 2021

As is stated in the recent specification change :

http.url MUST NOT contain credentials passed via URL in form of https://username:[email protected]/. In such case the attribute's value should be https://www.example.com/

At least all usages of OriginalString should be reviewed. E.g. https://github.com/open-telemetry/opentelemetry-dotnet/blob/main/src/OpenTelemetry.Instrumentation.Http/Implementation/HttpHandlerDiagnosticListener.cs#L115

PS. I can probably make a PR for it next week.
@pellared pellared added the enhancement New feature or request label Mar 9, 2021
@pellared pellared mentioned this issue Apr 6, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pellared pellared

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Sanitize http.url attribute pellared/opentelemetry-dotnet
1 participant
@pellared