Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appetite for ASMX and WCF support in .NET Framework?? #1784

Closed
notcool11 opened this issue Feb 3, 2021 · 2 comments
Closed

Appetite for ASMX and WCF support in .NET Framework?? #1784

notcool11 opened this issue Feb 3, 2021 · 2 comments

Comments

@notcool11
Copy link
Contributor

Sorry if issue is not the right place for this, happy to move it if needed.

Searching through the repo I didn't see any mention of ASMX and only a couple comments on WCF. We have apps that are still heavily using these older technologies, but still wish to participate in tracing. Most importantly we don't want traces to die because they flow through one of these systems.

I've built out a Jaeger based tracing framework to both honor the tracing data passed in to ASMX and WCF services as well as context propagate when clients call to these older frameworks.

The WCF solution is Endpoint Behavior based, meaning implementation can be done easily through .config files for both inbound and outbound context propagation.

ASMX inbound is just a Web Request so HttpModules work fine there. Howerver, the outbound propagation is a bit trickier because that technology was built before Dependency Injection was a thing. I'm using partial classes to extend ASMX Web References to get access to the GetWebResponse method. It's annoying depending on how many ASMX references you have, but I couldn't find a better way.

Because .NET 3.5 is still supported on Server 2019, I don't see ASMX or WCF going away any time soon. I'd like to see support for WCF and ASMX published, but before bothering with a PR I wanted to see if this is even something that would be appreciated. Thanks.

-Tyler

@cijothomas
Copy link
Member

open-telemetry/opentelemetry-dotnet-contrib#38 There is an active PR (draft) in contrib repo for WCF instrumentation. We are likely to maintain all the instrumentations in the -contrib repo, and its best to open an issue in that repo, and PRs for any new instrumentation.

OpenTelemetry .NET is built on top of DiagnosticSource package version 5.0. (https://www.nuget.org/packages/system.diagnostics.diagnosticsource) That package's minimum support is .NET45, so I don't think its possible to support .NET 3.5 apps

@notcool11
Copy link
Contributor Author

Right on, thanks for pointing to the other other repo and the specific PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants