Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can .NET support "No explicit parent Span/SpanContext allowed" spec item? #1676

Open
Oberon00 opened this issue Dec 29, 2020 · 3 comments
Open
Labels
needs-runtime-change Issues which likely require changes from dotnet runtime - typically DiagnosticSource package

Comments

@Oberon00
Copy link
Member

Oberon00 commented Dec 29, 2020

The tracing API specification was changed on September 23 to only allow a full Context as explicit parent, and a SpanContext alone or Span alone is no longer allowed. Spec references:

(How) is .NET going to implement this change?

Relatedly, I see the spec compliance matrix has "unknown" listed in this row https://github.com/open-telemetry/opentelemetry-specification/blob/master/spec-compliance-matrix.md#traces "No explicit parent Span/SpanContext allowed".

@Oberon00 Oberon00 added the question Further information is requested label Dec 29, 2020
@cijothomas
Copy link
Member

Thanks for raising this.
Can't think of an easy fix here in Otel repo. We need to plan and propose something for the next .NET cycle, as this won't be a trivial change. Keeping this issue open.

@cijothomas cijothomas added needs-runtime-change Issues which likely require changes from dotnet runtime - typically DiagnosticSource package and removed question Further information is requested labels Jan 29, 2021
Copy link
Contributor

This issue was marked stale due to lack of activity and will be closed in 7 days. Commenting will instruct the bot to automatically remove the label. This bot runs once per day.

@github-actions github-actions bot added the Stale Issues and pull requests which have been flagged for closing due to inactivity label Aug 17, 2024
@cijothomas cijothomas removed the Stale Issues and pull requests which have been flagged for closing due to inactivity label Aug 19, 2024
@cijothomas
Copy link
Member

Un-stale. This issue is unresolved.
Due to the use of async-local everywhere to pass around implicit Context, I think no-one is actually hitting any issue, but its still better to keep issue as open given this is a spec requirement that .NET is not able to comply with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-runtime-change Issues which likely require changes from dotnet runtime - typically DiagnosticSource package
Projects
None yet
Development

No branches or pull requests

2 participants