Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow arrays of primitives in Resource Attribute Values #1652

Closed
Austin-Tan opened this issue Dec 10, 2020 · 3 comments · Fixed by #1852
Closed

Allow arrays of primitives in Resource Attribute Values #1652

Austin-Tan opened this issue Dec 10, 2020 · 3 comments · Fixed by #1852
Assignees
Labels
enhancement New feature or request

Comments

@Austin-Tan
Copy link
Member

Feature Request

Follow up to #1647 , where it was pointed out that arrays of primitives should be allowed as the value in KV pairs as per spec.

Describe the solution you'd like:

Our current behavior will throw an exception (post #1647) if invalid data types are used as the values.

Describe alternatives you've considered.

We have an obligation to the spec to support this, right? I'm not sure about the extent to which we currently achieve everything the spec prescribes.

Additional Context

Add any other context about the feature request here.

@Austin-Tan Austin-Tan added the enhancement New feature or request label Dec 10, 2020
@Austin-Tan
Copy link
Member Author

Current issue in OTel specification:
open-telemetry/opentelemetry-specification#1184
Don't want to work on this until this is confirmed.

@cijothomas
Copy link
Member

@Austin-Tan the spec issue is ready to be closed. We can address this now.

@Austin-Tan
Copy link
Member Author

Sounds good, feel free to assign this to me. I'll work on this today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants