Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instrumentations and overriding Propagator #1439

Closed
cijothomas opened this issue Nov 3, 2020 · 3 comments · Fixed by #1448
Closed

Instrumentations and overriding Propagator #1439

cijothomas opened this issue Nov 3, 2020 · 3 comments · Fixed by #1448
Assignees
Labels
question Further information is requested

Comments

@cijothomas
Copy link
Member

#581 is resolved as we added Global Propagators API which allow one to retrieve the Global propagator, and SDK sets the default to Composite (Baggae, TraceContext).

Opening this issue to discuss if we need to still allow Instrumentations to override their Propagator. Its not really mentioned in the spec, but there could be use cases where a specific instrumentation requires non-default propagator.

@cijothomas cijothomas added the question Further information is requested label Nov 3, 2020
@eddynaka
Copy link
Contributor

eddynaka commented Nov 3, 2020

Question: is it common for people to enable different Propagators for different instrumentations? For example:

  • http -> w3c only
  • aspnetcore -> all

If we go to the way where we remove the propagators from options, that won't be possible anymore unless u start many SDK's and, in each SDK you add one instrumentation or something like that.

@cijothomas
Copy link
Member Author

yes, if we remove the propagator from individual instrumentation options, then every instrumentation get the same global propagator with no ability to override. Spec doesn't say that instrumentations may ignore the global propagator either. So its upto us for now, to decide if we want to allow this or not.

I am okay to remove this for now, and if a need comes up, we can always add it then. (The reverse is not easy after GA.)

@cijothomas
Copy link
Member Author

From today's Sig meeting: Remove the option from instrumentation.
Keep an issue open for adding back if required after GA.
This is done to make sure we dont expose any public API unless there is strong reason and the requirements are clear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants