Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sampler attributes must be part of activity for legacy instrumentation #1245

Closed
cijothomas opened this issue Sep 9, 2020 · 0 comments · Fixed by #1247
Closed

Sampler attributes must be part of activity for legacy instrumentation #1245

cijothomas opened this issue Sep 9, 2020 · 0 comments · Fixed by #1247
Assignees
@cijothomas
Labels
bug Something isn't working
Milestone
0.6.0-beta (Beta 3)

Comments

@cijothomas
Copy link
Member

#953 is fixed for activities created using ActivitySource. The same must be fixed for legacy/old (DiagnosticSource based) instrumentations as well.
@cijothomas cijothomas added the bug Something isn't working label Sep 9, 2020
@cijothomas cijothomas added this to the 0.6.0-beta (Beta 3) milestone Sep 9, 2020
@cijothomas cijothomas self-assigned this Sep 9, 2020
@cijothomas cijothomas mentioned this issue Sep 9, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cijothomas cijothomas

Labels
bug Something isn't working
Projects
None yet
Milestone
0.6.0-beta (Beta 3)
Development

Successfully merging a pull request may close this issue.

ActivitySource adapter to populate sampler attributes to activity cijothomas/opentelemetry-dotnet
1 participant
@cijothomas