You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
ActivitySourceAdapter currently expose start and stop only, and internally calls GetSampling (equivalent) inside Start. Instead it must expose GetSampling, Start, Stop separately to aligh with the behaviour of actual ActivitySource. And to prevent issues like the one reported here: #1208
The text was updated successfully, but these errors were encountered:
The current method/behavior of Start is aligned with ActivitySource, which has StartActivity - which does Sampler invocation, and depending on outcome, OnStart callback is called.
ActivitySourceAdapter exposes Start (which is equivalent of activitySource.StartActivity) - this does Sampler invocation, and invokes OnStart. So there is no need to any change here.
ActivitySourceAdapter currently expose start and stop only, and internally calls GetSampling (equivalent) inside Start. Instead it must expose GetSampling, Start, Stop separately to aligh with the behaviour of actual ActivitySource. And to prevent issues like the one reported here: #1208
The text was updated successfully, but these errors were encountered: