Merge branch 'main' into 4484_aspnetcoreMetrics

open-telemetry · Aug 24, 2023 · b2c5b82 · b2c5b82
2 parents d4776ba + e330e57
commit b2c5b82
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/src/OpenTelemetry/CHANGELOG.md b/src/OpenTelemetry/CHANGELOG.md
@@ -2,6 +2,9 @@
 
 ## Unreleased
 
+* Increased the character limit of the Meter instrument name from 63 to 255.
+  ([#4774](https://github.com/open-telemetry/opentelemetry-dotnet/issues/4774))
+
 ## 1.6.0-rc.1
 
 Released 2023-Aug-21

diff --git a/src/OpenTelemetry/Metrics/Builder/MeterProviderBuilderSdk.cs b/src/OpenTelemetry/Metrics/Builder/MeterProviderBuilderSdk.cs
@@ -48,7 +48,7 @@ public MeterProviderBuilderSdk(IServiceProvider serviceProvider)
     // Customers: This is not guaranteed to work forever. We may change this
     // mechanism in the future do this at your own risk.
     public static Regex InstrumentNameRegex { get; set; } = new(
-        @"^[a-z][a-z0-9-._]{0,62}$", RegexOptions.IgnoreCase | RegexOptions.Compiled);
+        @"^[a-z][a-z0-9-._]{0,254}$", RegexOptions.IgnoreCase | RegexOptions.Compiled);
 
     public List<InstrumentationRegistration> Instrumentation { get; } = new();
 

diff --git a/test/OpenTelemetry.Tests/Metrics/MetricTestData.cs b/test/OpenTelemetry.Tests/Metrics/MetricTestData.cs
@@ -25,7 +25,7 @@ public static IEnumerable<object[]> InvalidInstrumentNames
                 new object[] { "-first-char-not-alphabetic" },
                 new object[] { "1first-char-not-alphabetic" },
                 new object[] { "invalid+separator" },
-                new object[] { new string('m', 64) },
+                new object[] { new string('m', 256) },
                 new object[] { "a\xb5" }, // `\xb5` is the Micro character
        };
 
@@ -37,7 +37,7 @@ public static IEnumerable<object[]> ValidInstrumentNames
                 new object[] { "my-2-instrument" },
                 new object[] { "my.metric" },
                 new object[] { "my_metric2" },
-                new object[] { new string('m', 63) },
+                new object[] { new string('m', 255) },
                 new object[] { "CaSe-InSeNsItIvE" },
        };