From 6a49bba663bbbe1e066374a06dcda614a0652112 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Piotr=20Kie=C5=82kowicz?= Date: Wed, 20 Jul 2022 08:29:07 +0200 Subject: [PATCH] typo fixes --- .../Metrics/MeterProviderBuilderExtensions.cs | 2 +- .../OtlpExporterOptionsExtensionsTests.cs | 4 ++-- .../OtlpLogExporterTests.cs | 2 +- .../OtlpTraceExporterTests.cs | 2 +- .../Shared/TestEventListener.cs | 2 +- .../Trace/TracerProviderSdkTest.cs | 16 ++++++++-------- 6 files changed, 14 insertions(+), 14 deletions(-) diff --git a/src/OpenTelemetry/Metrics/MeterProviderBuilderExtensions.cs b/src/OpenTelemetry/Metrics/MeterProviderBuilderExtensions.cs index c9ab4726712..cd47974872c 100644 --- a/src/OpenTelemetry/Metrics/MeterProviderBuilderExtensions.cs +++ b/src/OpenTelemetry/Metrics/MeterProviderBuilderExtensions.cs @@ -137,7 +137,7 @@ public static MeterProviderBuilder AddView(this MeterProviderBuilder meterProvid /// Sets the maximum number of Metric streams supported by the MeterProvider. /// When no Views are configured, every instrument will result in one metric stream, /// so this control the numbers of instruments supported. - /// When Views are configued, a single instrument can result in multiple metric streams, + /// When Views are configured, a single instrument can result in multiple metric streams, /// so this control the number of streams. /// /// MeterProviderBuilder instance. diff --git a/test/OpenTelemetry.Exporter.OpenTelemetryProtocol.Tests/OtlpExporterOptionsExtensionsTests.cs b/test/OpenTelemetry.Exporter.OpenTelemetryProtocol.Tests/OtlpExporterOptionsExtensionsTests.cs index 4b4dd25fd53..bc68e4349f6 100644 --- a/test/OpenTelemetry.Exporter.OpenTelemetryProtocol.Tests/OtlpExporterOptionsExtensionsTests.cs +++ b/test/OpenTelemetry.Exporter.OpenTelemetryProtocol.Tests/OtlpExporterOptionsExtensionsTests.cs @@ -30,7 +30,7 @@ public class OtlpExporterOptionsExtensionsTests : Http2UnencryptedSupportTests [InlineData("key1 = value1, key2=value2 ", new string[] { "key1", "key2" }, new string[] { "value1", "value2" })] [InlineData("key==value", new string[] { "key" }, new string[] { "=value" })] [InlineData("access-token=abc=/123,timeout=1234", new string[] { "access-token", "timeout" }, new string[] { "abc=/123", "1234" })] - [InlineData("key1=value1;key2=value2", new string[] { "key1" }, new string[] { "value1;key2=value2" })] // semicolon is not treated as a delimeter (https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/protocol/exporter.md#specifying-headers-via-environment-variables) + [InlineData("key1=value1;key2=value2", new string[] { "key1" }, new string[] { "value1;key2=value2" })] // semicolon is not treated as a delimiter (https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/protocol/exporter.md#specifying-headers-via-environment-variables) public void GetMetadataFromHeadersWorksCorrectFormat(string headers, string[] keys, string[] values) { var options = new OtlpExporterOptions @@ -73,7 +73,7 @@ public void GetMetadataFromHeadersThrowsExceptionOnInvalidFormat(string headers) [Theory] [InlineData("")] [InlineData(null)] - public void GetHeaders_NoOptionHeaders_ReturnsEmptyHeadres(string optionHeaders) + public void GetHeaders_NoOptionHeaders_ReturnsEmptyHeaders(string optionHeaders) { var options = new OtlpExporterOptions { diff --git a/test/OpenTelemetry.Exporter.OpenTelemetryProtocol.Tests/OtlpLogExporterTests.cs b/test/OpenTelemetry.Exporter.OpenTelemetryProtocol.Tests/OtlpLogExporterTests.cs index 362045da1ad..03006ecfdfc 100644 --- a/test/OpenTelemetry.Exporter.OpenTelemetryProtocol.Tests/OtlpLogExporterTests.cs +++ b/test/OpenTelemetry.Exporter.OpenTelemetryProtocol.Tests/OtlpLogExporterTests.cs @@ -33,7 +33,7 @@ namespace OpenTelemetry.Exporter.OpenTelemetryProtocol.Tests public class OtlpLogExporterTests : Http2UnencryptedSupportTests { [Fact] - public void AddOtlpLogExporterOptionstest() + public void AddOtlpLogExporterOptionsTest() { AppContext.SetSwitch("System.Net.Http.SocketsHttpHandler.Http2UnencryptedSupport", true); var loggerOptions = new OpenTelemetryLoggerOptions(); diff --git a/test/OpenTelemetry.Exporter.OpenTelemetryProtocol.Tests/OtlpTraceExporterTests.cs b/test/OpenTelemetry.Exporter.OpenTelemetryProtocol.Tests/OtlpTraceExporterTests.cs index 3dd760c4190..56a8df672cd 100644 --- a/test/OpenTelemetry.Exporter.OpenTelemetryProtocol.Tests/OtlpTraceExporterTests.cs +++ b/test/OpenTelemetry.Exporter.OpenTelemetryProtocol.Tests/OtlpTraceExporterTests.cs @@ -375,7 +375,7 @@ public void ToOtlpSpanNativeActivityStatusTest(ActivityStatusCode expectedStatus } [Theory] - [InlineData(StatusCode.Unset, "Unset", "Description will be ingored if status is Unset.")] + [InlineData(StatusCode.Unset, "Unset", "Description will be ignored if status is Unset.")] [InlineData(StatusCode.Ok, "Ok", "Description must only be used with the Error StatusCode.")] [InlineData(StatusCode.Error, "Error", "Error description.")] public void ToOtlpSpanStatusTagTest(StatusCode expectedStatusCode, string statusCodeTagValue, string statusDescription) diff --git a/test/OpenTelemetry.Tests/Shared/TestEventListener.cs b/test/OpenTelemetry.Tests/Shared/TestEventListener.cs index 9c6ffc3e562..edff6577ca9 100644 --- a/test/OpenTelemetry.Tests/Shared/TestEventListener.cs +++ b/test/OpenTelemetry.Tests/Shared/TestEventListener.cs @@ -90,7 +90,7 @@ protected override void OnEventWritten(EventWrittenEventArgs eventData) /// The event source that was created. protected override void OnEventSourceCreated(EventSource eventSource) { - // Check for null because this method is called by the base class constror before we can initialize it + // Check for null because this method is called by the base class constructor before we can initialize it Action callback = this.OnOnEventSourceCreated; callback?.Invoke(eventSource); } diff --git a/test/OpenTelemetry.Tests/Trace/TracerProviderSdkTest.cs b/test/OpenTelemetry.Tests/Trace/TracerProviderSdkTest.cs index 7463df95843..e487d334e39 100644 --- a/test/OpenTelemetry.Tests/Trace/TracerProviderSdkTest.cs +++ b/test/OpenTelemetry.Tests/Trace/TracerProviderSdkTest.cs @@ -419,7 +419,7 @@ public void SdkDoesNotProcessLegacyActivityWithNoAdditionalConfig() (a) => { Assert.False(Sdk.SuppressInstrumentation); - Assert.True(a.IsAllDataRequested); // If Proccessor.OnStart is called, activity's IsAllDataRequested is set to true + Assert.True(a.IsAllDataRequested); // If Processor.OnStart is called, activity's IsAllDataRequested is set to true startCalled = true; }; @@ -476,7 +476,7 @@ public void SdkSamplesAndProcessesLegacyActivityWithRightConfig() { Assert.True(samplerCalled); Assert.False(Sdk.SuppressInstrumentation); - Assert.True(a.IsAllDataRequested); // If Proccessor.OnStart is called, activity's IsAllDataRequested is set to true + Assert.True(a.IsAllDataRequested); // If Processor.OnStart is called, activity's IsAllDataRequested is set to true startCalled = true; }; @@ -537,7 +537,7 @@ public void SdkSamplesAndProcessesLegacyActivityWithRightConfigOnWildCardMode() { Assert.True(samplerCalled); Assert.False(Sdk.SuppressInstrumentation); - Assert.True(a.IsAllDataRequested); // If Proccessor.OnStart is called, activity's IsAllDataRequested is set to true + Assert.True(a.IsAllDataRequested); // If Processor.OnStart is called, activity's IsAllDataRequested is set to true startCalled = true; }; @@ -586,7 +586,7 @@ public void SdkCallsOnlyProcessorOnStartForLegacyActivityWhenActivitySourceIsUpd (a) => { Assert.False(Sdk.SuppressInstrumentation); - Assert.True(a.IsAllDataRequested); // If Proccessor.OnStart is called, activity's IsAllDataRequested is set to true + Assert.True(a.IsAllDataRequested); // If Processor.OnStart is called, activity's IsAllDataRequested is set to true startCalled = true; }; @@ -635,7 +635,7 @@ public void SdkProcessesLegacyActivityWhenActivitySourceIsUpdatedWithAddSource() (a) => { Assert.False(Sdk.SuppressInstrumentation); - Assert.True(a.IsAllDataRequested); // If Proccessor.OnStart is called, activity's IsAllDataRequested is set to true + Assert.True(a.IsAllDataRequested); // If Processor.OnStart is called, activity's IsAllDataRequested is set to true startCalled = true; }; @@ -684,7 +684,7 @@ public void SdkProcessesLegacyActivityEvenAfterAddingNewProcessor() (a) => { Assert.False(Sdk.SuppressInstrumentation); - Assert.True(a.IsAllDataRequested); // If Proccessor.OnStart is called, activity's IsAllDataRequested is set to true + Assert.True(a.IsAllDataRequested); // If Processor.OnStart is called, activity's IsAllDataRequested is set to true startCalled = true; }; @@ -724,7 +724,7 @@ public void SdkProcessesLegacyActivityEvenAfterAddingNewProcessor() (a) => { Assert.False(Sdk.SuppressInstrumentation); - Assert.True(a.IsAllDataRequested); // If Proccessor.OnStart is called, activity's IsAllDataRequested is set to true + Assert.True(a.IsAllDataRequested); // If Processor.OnStart is called, activity's IsAllDataRequested is set to true startCalledNew = true; }; @@ -1126,7 +1126,7 @@ public void SdkSamplesAndProcessesLegacySourceWhenAddLegacySourceIsCalledWithWil { Assert.Contains(a.OperationName, sampledActivities); Assert.False(Sdk.SuppressInstrumentation); - Assert.True(a.IsAllDataRequested); // If Proccessor.OnStart is called, activity's IsAllDataRequested is set to true + Assert.True(a.IsAllDataRequested); // If Processor.OnStart is called, activity's IsAllDataRequested is set to true onStartProcessedActivities.Add(a.OperationName); };