Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote poc-sdk-otel branch to main #226

Closed
pellared opened this issue Sep 30, 2021 · 5 comments
Closed

Promote poc-sdk-otel branch to main #226

pellared opened this issue Sep 30, 2021 · 5 comments

Comments

@pellared
Copy link
Member

pellared commented Sep 30, 2021

Why

This issue is created to have a "signup" if the design proposed in poc-sdk-otel branch is how we plan to evolve the project. This would mean that we can use it as the main branch (and abandon the current main branch).

Initial design docs

There would be a separate issue to track what we would consider as ALPHA or even BETA release. We are probably missing good user documentation.

What is included

  • SDK-based instrumentations; more
    • HTTP client
    • ASP.NET
    • ASP.NET Core
    • SQL Server client
  • profiler-based (IL-rewrite) instrumentations; more
    • MongoDB client
    • GraphQL server
  • Plugin support using OTEL_DOTNET_TRACER_INSTRUMENTATION_PLUGINS; more

What scenarios were checked

  • Using ActivitySource API. See: here
  • Assembly versioning conflicts. See: here and here

What is missing (but probably not blocking)

  • building "artifacts" (even zip files that can be extracted and used)
  • usage and readme docs update and cleanup
  • developing docs update
  • more integration tests for existing code

Lots of other stuff but probably the ☝️ is the most important if we would like anyone to use the output.

@pellared pellared changed the title Switch poc-sdk-otel to main [WIP] Switch poc-sdk-otel to main Sep 30, 2021
@pellared
Copy link
Member Author

pellared commented Oct 6, 2021

@RassK Can you confirm that the instrumentation works also for SNK-signed applications and on IIS?

@pellared pellared changed the title [WIP] Switch poc-sdk-otel to main Switch poc-sdk-otel to main Oct 6, 2021
@pellared pellared changed the title Switch poc-sdk-otel to main Promote poc-sdk-otel branch to main Oct 6, 2021
@pjanotti
Copy link
Contributor

pjanotti commented Oct 6, 2021

Yes, as we discussed in previous meetings it is time. Let's merge the latest upstream pull and then make the switch. We should target this to be done by 10/13.

@zacharycmontoya
Copy link
Contributor

Agreed, let's prioritize this

@nrcventura
Copy link
Member

Yes. We should also call out aspnetcore as a separate thing that we also support.

@pjanotti
Copy link
Contributor

This was done. Update your local branch names by using

git branch -m main legacy-main
git fetch origin
git branch -u origin/legacy-main legacy-main
git remote set-head origin -a

git branch -m poc-otel-sdk main
git fetch origin
git branch -u origin/main main
git remote set-head origin -a

If you want to remove old tracking references use:

git remote prune origin

See https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/managing-branches-in-your-repository/renaming-a-branch#updating-a-local-clone-after-a-branch-name-changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants