-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document OTEL_EXPORTER_OTLP_METRICS_TEMPORALITY_PREFERENCE environment variable #1405
Comments
Thanks for reporting the issue. I created a similar one in the OTel .NET SDK: open-telemetry/opentelemetry-dotnet#3756 |
Hi, @pellared thanks for creating the issue in the core repo. 🙂 I was not sure if here is the right place, or if I should open it in the core repo, but as the condition part of this spec
is implemented in this repo, I opted to open the issue here instead. 🙂 If there's a consensus where this feature belongs then I can also dedicate some time to implement this if necessary. 🙂 |
@pichlermarc, we have a plan release 0.4.0-beta shortly. If it is important feature for you we can include it into this code base. If it can wait it should be implemented in the api/sdk repository. Upgrade path for OTel API/SDK 1.4.0 will be more complicated and it will take more time.
Sounds great! |
It is fine to implement it here before it is supported via the SDK 👍 We are open to your contribution 🎉 |
@pichlermarc Are you working on it? Do you need any help? |
@pellared, sorry, I did not get around to doing this yet. :/ |
This PR adds a workaround for a moment missing direct configuration option. |
Hi, I just went over old issues I created and this seems to be already implemented. I just tried this out using the automatic instrumentation docs on opentelemetry.io, switched the exporter to OTLP and set up the environment variable. Big thanks to the person who took care of that 🙂 |
Reopening as the environment variable is not documented. |
Feature Request
Is your feature request related to a problem? Please describe.
Currently the
OTEL_EXPORTER_OTLP_METRICS_TEMPORALITY_PREFERENCE
enviornment variable is not used to configure the export temporality (see here).The spec states that:
Describe the solution you'd like
Allow configuration of aggregation temporality via
OTEL_EXPORTER_OTLP_METRICS_TEMPORALITY_PREFERENCE
Additional context
As this is a MUST requirement in the spec, this might also be a bug.
The text was updated successfully, but these errors were encountered: