Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Full DI support for GenevaTraceExporter #938

Closed
1 of 2 tasks
cijothomas opened this issue Jan 30, 2023 · 1 comment
Closed
1 of 2 tasks

Full DI support for GenevaTraceExporter #938

cijothomas opened this issue Jan 30, 2023 · 1 comment
Assignees
@cijothomas
Labels
comp:exporter.geneva Things related to OpenTelemetry.Exporter.Geneva

Comments

@cijothomas
Copy link
Member

cijothomas commented Jan 30, 2023 •
edited
Loading

Is this a feature request or a bug?

  • Feature Request
  • Bug

What is the expected behavior?
#925 allowed additional configuration options for AddGenevaTraceExporter, however it still does not allow reading exporteroptions from the app's IConfiguration, if any.
The ask is to follow the recommendation from the OTel SDK : https://github.com/open-telemetry/opentelemetry-dotnet/tree/main/docs/trace/extending-the-sdk#registration-extension-method-guidance-for-library-authors
@cijothomas cijothomas added the comp:exporter.geneva Things related to OpenTelemetry.Exporter.Geneva label Jan 30, 2023
@cijothomas cijothomas self-assigned this Jan 30, 2023
@vishweshbankwar
Copy link
Member

This was addressed in #1218

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cijothomas cijothomas

Labels
comp:exporter.geneva Things related to OpenTelemetry.Exporter.Geneva
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cijothomas @vishweshbankwar