Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sql] Include instance name in db.namespace #2236

Closed
alanwest opened this issue Oct 22, 2024 · 0 comments · Fixed by #2277
Closed

[sql] Include instance name in db.namespace #2236

alanwest opened this issue Oct 22, 2024 · 0 comments · Fixed by #2277
Assignees
Labels
comp:instrumentation.sqlclient Things related to OpenTelemetry.Instrumentation.SqlClient

Comments

@alanwest
Copy link
Member

The MSSQL conventions require db.namespace to be qualified by the instance name.

[3]: When connected to a default instance, db.namespace SHOULD be set to the name of the database. When connected to a named instance, db.namespace SHOULD be set to the combination of instance and database name following the {instance_name}.{database_name} pattern.

Currently, the instance name is parsed from the data source string and captured as the deprecated db.mssql.instance_name attribute.

Including the instance name in the db.namespace is required, so this may influence the conversation on #2235.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:instrumentation.sqlclient Things related to OpenTelemetry.Instrumentation.SqlClient
Projects
None yet
1 participant