Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[http] Update Trace Instrumentation to align with changes in .NET 9.0 #2029

Closed
vishweshbankwar opened this issue Aug 29, 2024 · 0 comments · Fixed by #2314
Closed

[http] Update Trace Instrumentation to align with changes in .NET 9.0 #2029

vishweshbankwar opened this issue Aug 29, 2024 · 0 comments · Fixed by #2314
Assignees
Labels
comp:instrumentation.http Things related to OpenTelemetry.Instrumentation.Http enhancement New feature or request

Comments

@vishweshbankwar
Copy link
Member

Component

OpenTelemetry.Instrumentation.Http

Is your feature request related to a problem?

Starting with .NET 9.0, HttpClient will automatically add tags to activities by default dotnet/runtime PR #104251, following the HTTP semantic conventions. To avoid redundant tagging within our instrumentation, we need to skip adding these tags for targets running on .NET 9.0 and above. This is the only adjustment required.

We will continue supporting the Enrich and Filters callbacks since the equivalent APIs are not affected by the changes in .NET 9.0.

It's essential to ensure consistent behavior in .NET 9.0 compared to earlier versions to prevent breaking changes for users migrating to .NET 9.0.

What is the expected behavior?

Continued support for http instrumentation for users targeting .NET9.0

Which alternative solutions or features have you considered?

NA

Additional context

No response

@vishweshbankwar vishweshbankwar added the enhancement New feature or request label Aug 29, 2024
@github-actions github-actions bot added the comp:instrumentation.http Things related to OpenTelemetry.Instrumentation.Http label Aug 29, 2024
@CodeBlanch CodeBlanch added this to the CoreInstrumentation-1.10.0 milestone Oct 1, 2024
@CodeBlanch CodeBlanch changed the title Update Trace Instrumentation to align with changes in .NET 9.0 [http] Update Trace Instrumentation to align with changes in .NET 9.0 Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:instrumentation.http Things related to OpenTelemetry.Instrumentation.Http enhancement New feature or request
Projects
None yet
3 participants