Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing net452 target from the package #1078

Closed
vishweshbankwar opened this issue Mar 14, 2023 · 6 comments · Fixed by #1095
Closed

Consider removing net452 target from the package #1078

vishweshbankwar opened this issue Mar 14, 2023 · 6 comments · Fixed by #1095
Labels
comp:instrumentation.aws Things related to OpenTelemetry.Instrumentation.AWS

Comments

@vishweshbankwar
Copy link
Member

Issue with OpenTelemetry.Contrib.Instrumentation.AWS

The package currently targets net452 which is a non-supported version. Consider updating it to latest supported version i.e. net462.

Additional Context

This issue is opened as part of #1031 effort

@vishweshbankwar
Copy link
Member Author

@srprash - Could you please take a look?

@srprash
Copy link
Contributor

srprash commented Mar 28, 2023

@vishweshbankwar I am okay with bumping up the supported framework to net462, but I think it should be done as a new major version since it is a breaking change.

Maybe we should cut a new branch to maintain the current major version and track the new major version in the main branch?

@utpilla @Kielek Any suggested strategy for moving a project to a new major version in this repo?

@vishweshbankwar
Copy link
Member Author

@srprash Removing Un-supported versions does not need major version bump. OTel Sdk has done that in the past open-telemetry/opentelemetry-dotnet#3191

@srprash
Copy link
Contributor

srprash commented Mar 28, 2023

I see. I need some clarity though. Suppose a net452 application user has pinned this package as

<PackageReference Include="OpenTelemetry.Contrib.Instrumentation.AWS" Version="[1.0.1,2.0.0)" />

Wouldn't dropping net452 in a non-major version break their application when they try to build it?

@cijothomas
Copy link
Member

I see. I need some clarity though. Suppose a net452 application user has pinned this package as

<PackageReference Include="OpenTelemetry.Contrib.Instrumentation.AWS" Version="[1.0.1,2.0.0)" />

Wouldn't dropping net452 in a non-major version break their application when they try to build it?

Not necessarily. It was done many times in the core Otel packages: (https://github.com/open-telemetry/opentelemetry-dotnet/blob/main/src/OpenTelemetry/CHANGELOG.md#120-alpha1) where it was generally agreed that dropping a target runtime (that is already out-of-support) can be done without major version bump.

@Kielek
Copy link
Contributor

Kielek commented Mar 28, 2023

It should be safe together with renaming package. Removing Contrib infix. No chance to accidentally reference thus version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:instrumentation.aws Things related to OpenTelemetry.Instrumentation.AWS
Projects
None yet
5 participants