Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Extensions.AWSXRay before release #1066

Closed
Kielek opened this issue Mar 9, 2023 · 0 comments · Fixed by #1232
Closed

Rename Extensions.AWSXRay before release #1066

Kielek opened this issue Mar 9, 2023 · 0 comments · Fixed by #1232
Labels
comp:extensions.aws Things related to OpenTelemetry.Extensions.AWS

Comments

@Kielek
Copy link
Contributor

Kielek commented Mar 9, 2023

          >>@srprash, @lupengamzn could you please check?

Would you review? And also comment on the breaking change/major version bump as well?

I agree that this must go out as a major version bump.

Just a reminder, in case of major bump, the whole package should be renamed. At least .Contrib infix has to be removed.

Yup. We can do that to be inline with the rest of the packages in the repo. I wish we can do the same for the OpenTelemetry.Contrib.Instrumentation.AWS package as well while bumping its major version.

If renaming the package is being considered, could we please replace XRay with AWS in the name?

I have no issues in dropping XRay and renaming the package to be OpenTelemetry.Contrib.Extensions.AWS. We had it with XRay because initially the package contained only the id-generator and the propagator very specific to AWS XRay.

Originally posted by @srprash in #875 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:extensions.aws Things related to OpenTelemetry.Extensions.AWS
Projects
None yet
1 participant