You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Would you review? And also comment on the breaking change/major version bump as well?
I agree that this must go out as a major version bump.
Just a reminder, in case of major bump, the whole package should be renamed. At least .Contrib infix has to be removed.
Yup. We can do that to be inline with the rest of the packages in the repo. I wish we can do the same for the OpenTelemetry.Contrib.Instrumentation.AWS package as well while bumping its major version.
If renaming the package is being considered, could we please replace XRay with AWS in the name?
I have no issues in dropping XRay and renaming the package to be OpenTelemetry.Contrib.Extensions.AWS. We had it with XRay because initially the package contained only the id-generator and the propagator very specific to AWS XRay.
I agree that this must go out as a major version bump.
Yup. We can do that to be inline with the rest of the packages in the repo. I wish we can do the same for the OpenTelemetry.Contrib.Instrumentation.AWS package as well while bumping its major version.
I have no issues in dropping XRay and renaming the package to be
OpenTelemetry.Contrib.Extensions.AWS
. We had it with XRay because initially the package contained only the id-generator and the propagator very specific to AWS XRay.Originally posted by @srprash in #875 (comment)
The text was updated successfully, but these errors were encountered: