Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review and enhance metric support for ad service service (Java) #73

Closed
6 tasks
cartersocha opened this issue May 30, 2022 · 2 comments
Closed
6 tasks
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@cartersocha
Copy link
Contributor

The following are requirements for metrics in the project. Not all services will meet all requirements.

  • Service metrics should not be duplicative of trace-derived metrics.
  • Services should emit multiple business metrics where appropriate.
  • Services should emit trace exemplars for their metrics.
  • Services should use push metrics where possible.
  • Services should explicitly read baggage where needed.
  • Collectors should perform metric transforms to normalize resource and service metrics.

Referencing issue: #43

@jlawrienyt
Copy link

jlawrienyt commented Jan 4, 2023

Proposed Solution:

The Ad Service already has some business logic around whether to deliver targeted ads or random ads, based on the context and ad availability. We should capture this decision as a single metric named app.ads.ad_requests with two dimensions: ad_request_type with possible values TARGETED and NOT_TARGETED; and ad_response_type with possible values TARGETED and RANDOM.

Currently, the code path that would serve a random ad is not being exercised by the load generator, nor is it possible to exercise it by browsing the demo site, because all products have categories with associated ads. I propose we add a new product in a new category that does not have an associated ad in order to demonstrate this behavior. We should probably do this regardless of the metrics change as the getRandomAds span is not currently getting produced.

cc @puckpuck

@austinlparker
Copy link
Member

Closing as basic metrics have been added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
No open projects
Development

No branches or pull requests

3 participants