Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review and enhance tracing support for ad service service (Java) #235

Closed
4 of 10 tasks
cartersocha opened this issue Jul 26, 2022 · 1 comment
Closed
4 of 10 tasks
Labels
enhancement New feature or request

Comments

@cartersocha
Copy link
Contributor

cartersocha commented Jul 26, 2022

The following is a list of requirements that we need to evaluate before declaring v1 for trace telemetry. These requirements are across the entire application; Not all services will meet all requirements. Determine the relevant features for this service.

  • Automatic Instrumentation is being used where appropriate.
  • Library instrumentation is being used if automatic instrumentation is unavailable.
  • Services extend automatic instrumentation.
    • New attributes/events attached to existing spans.
    • New spans are being created from existing spans.
  • Automatic and Manual Context Propagation are being demonstrated.
  • Telemetry is not being sampled upfront.
  • Telemetry is not being filtered upfront.
  • Baggage is being set and read appropriately (i.e., baggage must be explicitly set as attributes on spans)
  • Update the centralized tracing doc

Referencing: #42

Dependent on this item: #40

@cartersocha cartersocha added the enhancement New feature or request label Jul 26, 2022
@cartersocha cartersocha changed the title Review and enhance metric support for ad service service (Java) Review and enhance tracing support for ad service service (Java) Jul 26, 2022
@cartersocha
Copy link
Contributor Author

Tracing is code complete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant