Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Trace and Span IDs Generation #677

Closed
lalitb opened this issue Apr 16, 2021 · 0 comments · Fixed by #681
Closed

Custom Trace and Span IDs Generation #677

lalitb opened this issue Apr 16, 2021 · 0 comments · Fixed by #681
Labels
area:sdk release:required-for-ga To be resolved before GA release spec-compliance Not compliant to OpenTelemetry specs
Milestone

Comments

@lalitb
Copy link
Member

lalitb commented Apr 16, 2021

Custom IDs would allow users to set IDs that they need right at the beginning of a span. This is important if the downstream services or eventual backend that receives these spans need them to be in a certain format.

As per the specs:
https://github.com/open-telemetry/opentelemetry-specification/blob/b67faa4e0106cac194a837e3d419ae4fab9fc1c4/specification/trace/sdk.md#id-generators
The SDK MUST provide a mechanism for customizing the way IDs are generated for both the TraceId and the SpanId.

This is how other languages support it:
JS: https://github.com/open-telemetry/opentelemetry-js/blob/b7d6e74c5bec6a24f5d617d31402ea95c54f126f/packages/opentelemetry-core/src/trace/IdGenerator.ts

Java: https://github.com/open-telemetry/opentelemetry-java/blob/485cc52c6ff1bb3fa12cd950d6eb97d3ceae6e41/sdk/tracing/src/main/java/io/opentelemetry/sdk/trace/IdsGenerator.java

@lalitb lalitb added bug Something isn't working area:sdk release:required-for-ga To be resolved before GA release spec-compliance Not compliant to OpenTelemetry specs and removed bug Something isn't working labels Apr 16, 2021
@lalitb lalitb added this to the 1.0.0-rc.1 milestone Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:sdk release:required-for-ga To be resolved before GA release spec-compliance Not compliant to OpenTelemetry specs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant