Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow importing only the API package in projects #2543

Open
joaopgrassi opened this issue Feb 21, 2024 · 6 comments
Open

Allow importing only the API package in projects #2543

joaopgrassi opened this issue Feb 21, 2024 · 6 comments
Labels
enhancement New feature or request Stale triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@joaopgrassi
Copy link
Member

Is your feature request related to a problem?
I'm working in improving support of OTel in Envoy Proxy. Currently, Envoy has it's own tracing code, (not using OTel), but it has an Tracer/Exporter that exports OTLP spans.

We are adding OTel spec-compliant Samplers to it, and we would like to re-use some of the types in the OTel C++ API, mainly around TraceStates. Of course the ultimate goal would be to use the SDK there and not rely on their "fork" things, but that's a long term goal and not as straightforward.

The problem: The import instructions in Incorporating into an existing Bazel Project are targeted to import both the SDK and API packages. For the case of using in Envoy, I only need the API. By following the instructions, I will bring a lot of other unneeded dependencies.

Describe the solution you'd like
I'd like to have a way to import only the API package into existing bazel projects, that brings only the minimum needed dependencies along with it.

Describe alternatives you've considered
None, not sure if there's another bazel magic that can work around this issue. If there are, please let me know!

Additional context
PR discussion about it in Envoy https://github.com/envoyproxy/envoy/pull/32333/files#r1493892700

@github-actions github-actions bot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Feb 21, 2024
@ThomsonTan ThomsonTan added triage/accepted Indicates an issue or PR is ready to be actively worked on. enhancement New feature or request and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 21, 2024
Copy link

This issue was marked as stale due to lack of activity.

@github-actions github-actions bot added the Stale label Apr 23, 2024
@joaopgrassi
Copy link
Member Author

I guess this is not stale?

@lalitb lalitb removed the Stale label May 1, 2024
Copy link

github-actions bot commented Jul 1, 2024

This issue was marked as stale due to lack of activity.

@github-actions github-actions bot added the Stale label Jul 1, 2024
@joaopgrassi
Copy link
Member Author

joaopgrassi commented Jul 9, 2024

@open-telemetry/cpp-maintainers I guess the stale bot should ignore issues that are triage/accepted?

@marcalff
Copy link
Member

marcalff commented Jul 9, 2024

@open-telemetry/cpp-maintainers I guess the stale bot should ignore issues that are triage/accepted?

The stale bot can add stale tags, but stale issues are never closed in the opentelemetry-cpp repository:

CMake can only install API header files, but the bazel build does not support this option, so this is still relevant.

Copy link

This issue was marked as stale due to lack of activity.

@github-actions github-actions bot added the Stale label Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Stale triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

4 participants