Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grpc v1.56.2 support #2374

Closed
jhl07 opened this issue Oct 18, 2023 · 4 comments
Closed

grpc v1.56.2 support #2374

jhl07 opened this issue Oct 18, 2023 · 4 comments
Labels
triage/needs-information Indicates an issue needs more information in order to work on it.

Comments

@jhl07
Copy link

jhl07 commented Oct 18, 2023

Is your feature request related to a problem?
My project needs grpc v1.56.2 cpp library linking with opentelemetry-cpp.

Describe the solution you'd like
I confirmed that the connection works well in opentelemetry-cpp v1.11.0 with MT,MTd build in vs2022 build environment, using grpc v1.39.0.

Describe alternatives you've considered
Compatible with grpc v1.56.2.

Additional context
And if possible, it would be nice to have the option to disable the SSL feature in the WITH_OTLP_GRPC option.

Thanks.

@github-actions github-actions bot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Oct 18, 2023
@owent
Copy link
Member

owent commented Oct 18, 2023

You can use your own prebuilt libraries by set CMAKE_PACKAGE_PATH when building otel-cpp with cmake.

@marcalff marcalff added triage/needs-information Indicates an issue needs more information in order to work on it. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 18, 2023
@marcalff
Copy link
Member

With CMake, opentelemetry-cpp supports a bring-your-own dependency model.

Installing a grpc package to use in the build should work, please let us know if there are specific issues.

As for disabling SSL at build time, there are no such options.

@jhl07
Copy link
Author

jhl07 commented Oct 27, 2023

Referring to issue #2163,
I set all profobuf, gRPC, absl cmake find package paths to gRPC v1.56.2 version,
then lib build succeeded and ran well.
Thanks!

@marcalff
Copy link
Member

@jhl07 Thanks for the update.

Closing this issue then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage/needs-information Indicates an issue needs more information in order to work on it.
Projects
None yet
Development

No branches or pull requests

3 participants