-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue when mapping OpenTelemetry MinMaxSumCount aggregator to Prometheus Gauge metric #228
Comments
I would be happy for you to deviate from the specification, use the LastValue aggregator (to give the correct Prometheus Gauge) and let us sort this out later. The MMLSC proposal is stuck behind some OTLP negotiations, and it's possible we'll reject it and declare that LastValue is the correct default for ValueRecorder anyway. For the sake of getting something to work, reporting (Sum/Count) is not terrible. You can see this was debated already: open-telemetry/opentelemetry-specification#636 To be explicit, that's open-telemetry/oteps#117 and open-telemetry/oteps#118 |
(sorry we didn't get to discuss this in the SIG meeting today!) |
Thanks for your reply! I will use sum as a gauge at the current stage. If there is any update, I will modify my implementation then. |
This issue was marked as stale due to lack of activity. It will be closed in 7 days if no furthur activity occurs. |
Closed as inactive. Feel free to reopen if this is still an issue. |
Is your feature request related to a problem?
Yes. According to the specification here, we need to support
MinMaxSumCount
in OpenTelemetry. However, when I was translating OpenTelemetry metric data to Prometheus data type and mapping OpenTelemetry Aggregator to Prometheus, I referred to the specification here. The spec states we need to mapMinMaxLastSumCount
to Prometheus Gauge, and use the Last Value as the gauge metric. The problem is we don’t have aMinMaxLastSumCount
aggregator. What we have isMinMaxSumCount
aggregator but there is nothing can be mapped to gauge in this aggregator.Describe the solution you'd like
Ignore this aggregator when mapping from OpenTelemetry to Prometheus for now, if possible.
Choose another value in the aggregator (min, max, sum, or count) to expose as the Prometheus gauge metric.
Describe alternatives you've considered
MinMaxLastSumCount
Aggregator. This is not a preferred solution because the team that implemented the aggregators will end their internship next week. It’s not a good choice to ask them add new implementations at this point.The text was updated successfully, but these errors were encountered: