Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUILD] Environment variable OPENTELEMETRY_EXTERNAL_COMPONENT_PATH is checked incorrectly #2206

Closed
ThomsonTan opened this issue Jun 28, 2023 · 0 comments · Fixed by #2207
Closed

[BUILD] Environment variable OPENTELEMETRY_EXTERNAL_COMPONENT_PATH is checked incorrectly #2206

ThomsonTan opened this issue Jun 28, 2023 · 0 comments · Fixed by #2207
Assignees
@ThomsonTan
Labels
bug Something isn't working

Comments

@ThomsonTan
Copy link
Contributor

In the cmake file below, the environment variable is checked incorrectly. The prefix $ is not needed, or it checks whether the value of OPENTELEMETRY_EXTERNAL_COMPONENT_PATH is environment name.

opentelemetry-cpp/cmake/opentelemetry-build-external-component.cmake

Line 13 in efde010

if(DEFINED $ENV{OPENTELEMETRY_EXTERNAL_COMPONENT_PATH})

@ThomsonTan ThomsonTan added the bug Something isn't working label Jun 28, 2023
@ThomsonTan ThomsonTan mentioned this issue Jun 28, 2023
Merged
3 tasks
@ThomsonTan ThomsonTan self-assigned this Jun 28, 2023
@marcalff marcalff changed the title Environment variable OPENTELEMETRY_EXTERNAL_COMPONENT_PATH is checked incorrectly [BUILD] Environment variable OPENTELEMETRY_EXTERNAL_COMPONENT_PATH is checked incorrectly Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ThomsonTan ThomsonTan

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[BUILD] Fix if check on environment variable and add CMake variable ThomsonTan/opentelemetry-cpp
1 participant
@ThomsonTan