Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installed target name of prometheus export changes in v1.8.0 #1819

Closed
owent opened this issue Nov 29, 2022 · 3 comments · Fixed by #1820
Closed

Installed target name of prometheus export changes in v1.8.0 #1819

owent opened this issue Nov 29, 2022 · 3 comments · Fixed by #1820
Labels
bug Something isn't working

Comments

@owent
Copy link
Member

owent commented Nov 29, 2022

Describe your environment

Build System: CMake

What is the expected behavior?

The installed target name of prometheus export changes from opentelemetry-cpp::prometheus_exporter to opentelemetry-cpp::opentelemetry_exporter_prometheus when using cmake.Should it keep the old name?

What is the actual behavior?

The old codes link opentelemetry-cpp::prometheus_exporter can not compile.

@owent owent added the bug Something isn't working label Nov 29, 2022
@lalitb
Copy link
Member

lalitb commented Nov 29, 2022

This was deliberate, to keep it consistent with the naming for other targets. We can indicate it as breaking change in the release document ?

@lalitb lalitb changed the title Installed target name of prometheus export changes in v1.18.0 Installed target name of prometheus export changes in v1.8.0 Nov 29, 2022
@owent
Copy link
Member Author

owent commented Nov 29, 2022

This was deliberate, to keep it consistent with the naming for other targets. We can indicate it as breaking change in the release document ?

The target name in v1.8.0 is opentelemetry-cpp::opentelemetry_exporter_prometheus, while other exporters are opentelemetry-cpp::ostream_metrics_exporter, opentelemetry-cpp::otlp_http_metric_exporter, 'opentelemetry-cpp::otlp_grpc_metrics_exporter'.

All targets have opentelemetry-cpp:: prefix, is it redundant to add another opentelemetry_ prefix for prometheus exporter?

@lalitb lalitb mentioned this issue Nov 29, 2022
3 tasks
@lalitb
Copy link
Member

lalitb commented Nov 29, 2022

Ah. Got it. I was validating the generated cmake target names, and not the target names in the otel-cpp cmake config. Have fixed it in #1820. Please see if that works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants