Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI Tests to Allow SDK Exceptions #156

Closed
nholbrook opened this issue Jul 7, 2020 · 2 comments
Closed

Update CI Tests to Allow SDK Exceptions #156

nholbrook opened this issue Jul 7, 2020 · 2 comments
Labels
enhancement New feature or request Stale

Comments

@nholbrook
Copy link
Contributor

Is your feature request related to a problem?
During Monday's weekly meeting it was determined that, according to the spec, the SDK should be allowed to throw exceptions (i.e. when constructing samplers with invalid arguments). However, there is currently a CI test in place that is too strict and does not allow exceptions to thrown in any situation. This test needs to be updated to be more fine grained to prevent API functions from throwing across ABI boundaries, but to allow exceptions in situations like this.

Describe the solution you'd like
The CI tests should allow throwing exceptions in cases where they doesn't cross ABI boundaries, while still failing for exceptions that do.

Additional context
Current test: bazel build --copt=-fno-exceptions $BAZEL_OPTIONS //...

@pyohannes pyohannes added the enhancement New feature or request label Jul 9, 2020
@github-actions
Copy link

github-actions bot commented Dec 3, 2021

This issue was marked as stale due to lack of activity. It will be closed in 7 days if no furthur activity occurs.

@github-actions github-actions bot added the Stale label Dec 3, 2021
@github-actions
Copy link

Closed as inactive. Feel free to reopen if this is still an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Stale
Projects
None yet
Development

No branches or pull requests

2 participants