You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem?
During Monday's weekly meeting it was determined that, according to the spec, the SDK should be allowed to throw exceptions (i.e. when constructing samplers with invalid arguments). However, there is currently a CI test in place that is too strict and does not allow exceptions to thrown in any situation. This test needs to be updated to be more fine grained to prevent API functions from throwing across ABI boundaries, but to allow exceptions in situations like this.
Describe the solution you'd like
The CI tests should allow throwing exceptions in cases where they doesn't cross ABI boundaries, while still failing for exceptions that do.
Additional context
Current test: bazel build --copt=-fno-exceptions $BAZEL_OPTIONS //...
The text was updated successfully, but these errors were encountered:
Is your feature request related to a problem?
During Monday's weekly meeting it was determined that, according to the spec, the SDK should be allowed to throw exceptions (i.e. when constructing samplers with invalid arguments). However, there is currently a CI test in place that is too strict and does not allow exceptions to thrown in any situation. This test needs to be updated to be more fine grained to prevent API functions from throwing across ABI boundaries, but to allow exceptions in situations like this.
Describe the solution you'd like
The CI tests should allow throwing exceptions in cases where they doesn't cross ABI boundaries, while still failing for exceptions that do.
Additional context
Current test:
bazel build --copt=-fno-exceptions $BAZEL_OPTIONS //...
The text was updated successfully, but these errors were encountered: