You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I notice the new metrics implement is enabled only when building without ENABLE_METRICS_PREVIEW (bazel) and WITH_METRICS_PREVIEW (cmake). But it's not checked in most CI jobs. I think we should add some steps or jobs to build without them.
The text was updated successfully, but these errors were encountered:
This was discussed in today's community meeting - Should we instead remove validating CI builds for old metrics implementation? This would simplify the CI, and also gives a message that the old implementation is going to be cleaned up in the coming days.
Could we keep few CI jobs for the old metrics, just like LogName in log APIs? There are some projects use the old implements and it will take some time to migrate to the new one.
I think keep one job using bazel with new compiler and one jobs using cmake with gcc 4.8 would be enough.
Is your feature request related to a problem?
I notice the new metrics implement is enabled only when building without
ENABLE_METRICS_PREVIEW
(bazel) andWITH_METRICS_PREVIEW
(cmake). But it's not checked in most CI jobs. I think we should add some steps or jobs to build without them.The text was updated successfully, but these errors were encountered: