Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when using http_client_curl of v1.3.0 #1335

Closed
owent opened this issue Apr 19, 2022 · 2 comments · Fixed by #1336
Closed

Crash when using http_client_curl of v1.3.0 #1335

owent opened this issue Apr 19, 2022 · 2 comments · Fixed by #1336
Labels
bug Something isn't working

Comments

@owent
Copy link
Member

owent commented Apr 19, 2022

Describe your environment

OS: Linux
Version: v1.3.0
Build System: cmake

Steps to reproduce

Use both opentelemetry::api and opentelemetry::http_client_curl at the same time.

What is the actual behavior?

Screenshot_16503460452050

Additional context

When building opentelemetry_ext, we should link opentelemetry_ext with opentelemetry_api to import all definitions of opentelemetry_api.Without it the opentelemetry_ext will be built without std::string_view , abseil-cpp and etc. But when we use both opentelemetry_ext and other components together, it will use std::string_view , abseil-cpp and etc when compiler support them.

@owent owent added the bug Something isn't working label Apr 19, 2022
@ThomsonTan
Copy link
Contributor

Wondering whether it is possible to add a test to catch this kind of issue?

@owent
Copy link
Member Author

owent commented Apr 20, 2022

I'm not sure why unit test didn't find this problem.
The test ext.http.curl.curl_http_test only links opentelemetry_http_client_curl and opentelemetry_http_client_curl only links opentelemetry_ext. I also checked the flags to compiling opentelemetry_http_client_curl and didn't find HAVE_CPP_STDLIB or HAVE_ABSEIL. This problem should already be tested but it didn't crash on CI.
Maybe it's related to my compiler and STD library.(clang 14.0.1 with -stdlib=libc++)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants