-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for proxy #8339
add support for proxy #8339
Conversation
Signed-off-by: Hrittik Roy <[email protected]>
Co-authored-by: Juraci Paixão Kröhling <[email protected]>
Signed-off-by: Hrittik Roy <[email protected]>
@hrittikhere, do you have an status update regarding this one? |
Signed-off-by: Juraci Paixão Kröhling <[email protected]>
Signed-off-by: Juraci Paixão Kröhling <[email protected]>
@hrittikhere, are you able to fix the merge conflicts? |
@jpkrohling does this looks good? |
@jpkrohling did you get a chance to look into it? Let me know if there's any changes :) |
LGTM! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8339 +/- ##
==========================================
+ Coverage 90.31% 91.55% +1.24%
==========================================
Files 308 316 +8
Lines 15998 17117 +1119
==========================================
+ Hits 14448 15672 +1224
+ Misses 1259 1150 -109
- Partials 291 295 +4 ☔ View full report in Codecov by Sentry. |
Apparently, there's still a linting failure:
|
Changelog entry is missing, right? https://github.com/open-telemetry/opentelemetry-collector/blob/main/CONTRIBUTING.md#adding-a-changelog-entry |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Sure I'll add the changelog entry over the weekend. Sorry I missed the comments :( |
Co-authored-by: Andrzej Stencel <[email protected]>
I tried fixing the lint and I think it works. Maybe we can re run?
|
Sure, build started! |
I think we're good to go? The |
We just need an @open-telemetry/collector-maintainers to review and push the button! |
Co-authored-by: Alex Boten <[email protected]>
Co-authored-by: Alex Boten <[email protected]>
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Can we run the test coverage once more? :) |
Thank you for your patience and perseverance, @hrittikhere . |
Thanks @jpkrohling for the help throughout! Couldn't have done it without you :) |
**Description:** Adding a feature to support proxy configuration field in all exporters **Link to tracking Issue:** open-telemetry#5761 --------- Signed-off-by: Hrittik Roy <[email protected]> Signed-off-by: Juraci Paixão Kröhling <[email protected]> Co-authored-by: Juraci Paixão Kröhling <[email protected]> Co-authored-by: Juraci Paixão Kröhling <[email protected]> Co-authored-by: Andrzej Stencel <[email protected]> Co-authored-by: Alex Boten <[email protected]>
Description: <Describe what has changed.
Adding a feature to support proxy configuration field in all exporters
Link to tracking Issue: #5761
Testing: < Describe what testing was performed and which tests were added.>
Documentation: < Describe the documentation added.>