-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[confmap] fix bug of unmarshalling slice values #8017
[confmap] fix bug of unmarshalling slice values #8017
Conversation
Codecov ReportPatch coverage is
📢 Thoughts on this report? Let us know!. |
@dmitryax could you help review this pr? |
Please address comments from @bogdandrutu in #6163. I think we should not override with |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
I think it is already doing like that, in unit test, these two cases are also covered opentelemetry-collector/confmap/confmap_test.go Lines 449 to 472 in 4dc71d6
|
b17f50b
to
fc62788
Compare
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
still doing |
Signed-off-by: Ziqi Zhao <[email protected]>
89df7a6
to
9b48f51
Compare
Signed-off-by: Ziqi Zhao <[email protected]>
9b48f51
to
d14e9e3
Compare
@open-telemetry/collector-maintainers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for including the detailed documentation @fatsheep9146
Description:
fix the bug of unmarshalling slice values for package confmap
Link to tracking Issue:
fix #4001