Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[configgrpc] Update public methods to accept context.Context #9812

Closed
Tracked by #9490
TylerHelmuth opened this issue Mar 21, 2024 · 2 comments · Fixed by #9836
Closed
Tracked by #9490

[configgrpc] Update public methods to accept context.Context #9812

TylerHelmuth opened this issue Mar 21, 2024 · 2 comments · Fixed by #9836
Labels
area:config
Milestone
go.opentelemetry....

Comments

@TylerHelmuth
Copy link
Member

No description provided.

@TylerHelmuth TylerHelmuth mentioned this issue Mar 21, 2024
Closed
9 tasks
@AkhigbeEromo
Copy link
Contributor

hello @TylerHelmuth, while working on this issue I realized that all the public functions in configgrpc.go already accept context. The only public function that does not accept context is a deprecated function called SanitizedEndpoint()

@TylerHelmuth
Copy link
Member Author

@AkhigbeEromo correct. There is 1 more round of deprecation and then we'll be able to call this closed.

@TylerHelmuth TylerHelmuth mentioned this issue Mar 25, 2024
Merged
@mx-psi mx-psi closed this as completed in 4f56509 Apr 3, 2024
@TylerHelmuth TylerHelmuth moved this to Done in Collector: v1 Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:config
Projects
Collector: v1
Archived in project
Milestone
go.opentelemetry.io/collector/config/...
Development

Successfully merging a pull request may close this issue.

[configgrpc] remove deprecated funcs TylerHelmuth/opentelemetry-collector
2 participants
@TylerHelmuth @AkhigbeEromo