-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[confmap] Decide on how/whether to allow to configure confmap providers #6956
Comments
Here is the proposal to use url fragments. #6892 |
A concern I would have with passing a |
The other problem with this proposal is that the "URI" like configs are also embedded into the config (not only provided via CLI flags, where is that config coming from in that case)? |
Per last week's Collector SIG we can close this as wontfix, we decided that the way to support this will be by passing configuration as URI fragments. |
Is your feature request related to a problem? Please describe.
In both #6683 and open-telemetry/opentelemetry-collector-contrib/pull/14897 there are use cases where confmap providers need to have some sort of configuration passed to them.
Currently, while not explicitly enforced by an interface it is assumed that all providers have a constructor with signature
func New() confmap.Provider
that does not allow configuring it in any way.Describe the solution you'd like
Define a way to configure providers or decide that we are not going to support this. My preferred way of doing this for global settings would be to allow passing a
Config
struct to theNew
builder that is populated from CLI flags (example on this comment #6683 (review)). We would need to figure out a way to namespace the CLI flags.Describe alternatives you've considered
An alternative is to pass this in the URI (see #6683 (comment)) and handle specific configuration on each
Retrieve
call. This has the following implications:Retrieve
call happens. This may have performance implications.cc @Aneurysm9 @rapphil @neelayu
The text was updated successfully, but these errors were encountered: