Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prototype test friendly featureflags #4917

Closed
bogdandrutu opened this issue Feb 24, 2022 · 2 comments · Fixed by #5160
Closed

Prototype test friendly featureflags #4917

bogdandrutu opened this issue Feb 24, 2022 · 2 comments · Fixed by #5160
Labels
good first issue Good for newcomers help wanted Good issue for contributors to OpenTelemetry Service to pick up

Comments

@bogdandrutu
Copy link
Member

See the idea #4108 (comment)
@bogdandrutu bogdandrutu added good first issue Good for newcomers help wanted Good issue for contributors to OpenTelemetry Service to pick up labels Feb 24, 2022
@lastchiliarch
Copy link

I'd like to do this.

So I need to change the registry to public,and add an GetRegistry func to return the gloabl reg, Right?

I'm not sure about replace IsEnabled with Registry.IsEnabled.

@yankay yankay mentioned this issue Mar 8, 2022
Closed
@yankay
Copy link

yankay commented Mar 8, 2022

Hi @bogdandrutu, would you please review the PR.

@bogdandrutu bogdandrutu mentioned this issue Apr 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Good issue for contributors to OpenTelemetry Service to pick up
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change featureflags package to make it test friendly bogdandrutu/opentelemetry-collector
3 participants
@bogdandrutu @yankay @lastchiliarch