Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change in behaviour for otlp grpc exporter #4191

Closed
codeboten opened this issue Oct 12, 2021 · 2 comments · Fixed by #4196
Closed

change in behaviour for otlp grpc exporter #4191

codeboten opened this issue Oct 12, 2021 · 2 comments · Fixed by #4196
Assignees
Labels
bug Something isn't working

Comments

@codeboten
Copy link
Contributor

Describe the bug
The following change causes the default for the grpc exporter transport to change from secure to insecure. ebb0fbd#diff-2eb38d27ab53ca22abef502c1b39e68f28165a4eb3aa92e2c1d2314ab8991a59R194-R199

I reproduced the change in behaviour by using the same configuration both before and after this change.
This was the config:

exporters:
  logging:
      loglevel: debug
  otlp:
    endpoint: ingest.lightstep.com:443
    headers:
        "lightstep-access-token": "redacted"

The fix was to set the following options:

exporters:
  logging:
      loglevel: debug
  otlp:
    endpoint: ingest.lightstep.com:443
    headers:
        "lightstep-access-token": "redacted"
    tls:
      insecure: false

Two things I'm looking for with this issue:

  1. ensure the change in behaviour was intentional
  2. if so, ensure we have this documented in the changelog/release notes
@codeboten codeboten added the bug Something isn't working label Oct 12, 2021
@jpkrohling
Copy link
Member

This should not have happened and should be reverted. Making the connection secure by default was a conscious decision and it should remain like that.

@codeboten codeboten self-assigned this Oct 13, 2021
@codeboten
Copy link
Contributor Author

As discussed at the Oct 13 SIG meeting, this behaviour was unexpected. Will add a PR to reverse the behaviour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants