Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tracking Issue for Design Proposals] Refactor processors in core (Span, Attributes, Filter, etc.) #3185

Closed
bogdandrutu opened this issue May 14, 2021 · 5 comments
Assignees
Labels

Comments

@bogdandrutu
Copy link
Member

bogdandrutu commented May 14, 2021

Right now to change span names we have the "SpanProcessor" and to change the span Attributes we have AttributesProcessor which also changes LogRecord attributes but does not change Resource attributes where we have the ResourceProcessor for that (a.k.a a complete mess).

We need to have a better overall design of what processors we offer:

  1. One processor to mutate Span properties - name, attributes, etc.
  2. One processor to mutate LogRecords properties - name, body, attributes, etc.
  3. One processor to mutate Metrics properties - name, maybe attributes, maybe unit transformation, etc.
  4. One processor that mutates Resource. Should this be just a library that is included in the first two?
  5. etc.

So what we need to see first:

  1. High-level description of the processors that we want to offer and their capabilities.
  2. Need to investigate how the "matching/filtering" (which spans/logs/metrics do I apply the mutations) config looks like.
  3. Need to investigate how a mutation config looks like.

/cc @punya @bhautikpip @hossain-rayhan @alolita related to the other discussion.

@bogdandrutu bogdandrutu added this to the Phase2-GA-Roadmap milestone May 14, 2021
@bogdandrutu bogdandrutu changed the title Merge SpanProcessor with AttributesProcessor Refactor processors in core (Span, Attributes, Filter, etc.) May 14, 2021
@bogdandrutu bogdandrutu added the priority:p0 Critical label May 14, 2021
@alolita alolita added the release:required-for-ga Must be resolved before GA release label May 18, 2021
@hossain-rayhan
Copy link
Contributor

hossain-rayhan commented May 19, 2021

[wip] design doc- OTel processors: what we have vs we want to see. Feel free to modify and add comment.

@alolita alolita changed the title Refactor processors in core (Span, Attributes, Filter, etc.) [Overall Issue for Design Proposals] Refactor processors in core (Span, Attributes, Filter, etc.) May 20, 2021
@alolita alolita changed the title [Overall Issue for Design Proposals] Refactor processors in core (Span, Attributes, Filter, etc.) [Tracking Issue for Design Proposals] Refactor processors in core (Span, Attributes, Filter, etc.) May 20, 2021
@mxiamxia
Copy link
Member

mxiamxia commented Jun 8, 2021

Proposed a design on refactoring the current processors for mutating trace, metric and log data points.
OTel Core Data Mutation Processors Design

/cc @alolita

@bogdandrutu
Copy link
Member Author

Based on #3474 this is no longer a P0 for core, since all the affected components are moved to contrib.

@mxiamxia
Copy link
Member

The refactored processors will introduce the new configurations which have the breaking changes to the existing OTel Collector customers. We’ll need to discuss the new processors migration options for reducing the breaking changes impact. I will try to cover it in OTel processor enhancement proposal.

@mxiamxia
Copy link
Member

Made some major updates on OTel processors redesign Doc v2

Please help to review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants