Avoid duplicating With[Start|Shutdown] in processorhelper

[bogdandrutu]

Rather than needing to duplicate every componenthelper.Option here, might it be better to have something like this:

func WithComponentOptions(opts componenthelper.Option...) Option {
  return func( o *baseSettings) {
    o.componentOptions = opts
  }
}

[bogdandrutu]

See #2778 (comment)

[alolita]

@bogdandrutu can we close this issue given @punya's comments?

[alolita]

@bogdandrutu should this issue be closed?

[alolita]

This seems like a style-based decision. @Aneurysm9 had made a suggestion so @punya can we chat w Anthony and figure out the best practice in this case :-) ty!

[Aneurysm9]

I think @punya covered the pros/cons well in this comment. The important question is probably whether/how often we expect to add new options that can benefit from this change. If we don't, then maybe it's not worth it. The value of the change goes up with each additional option that can utilize it. v0v

[punya]

We haven't added any more "generic" options like Start and Shutdown since the time this issue first came up. To me, that's decent evidence that we don't need to optimize for ease of adding future options of this sort.