Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for deprecated unmarshaler #2591

Merged

Conversation

bogdandrutu
Copy link
Member

Updates #2540

@bogdandrutu bogdandrutu requested a review from a team March 3, 2021 16:59
@bogdandrutu bogdandrutu force-pushed the rmdeprecatedunmarshaler branch from d9f899c to 57d8f01 Compare March 3, 2021 16:59
@codecov
Copy link

codecov bot commented Mar 3, 2021

Codecov Report

Merging #2591 (f03072b) into main (bf6dc58) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2591      +/-   ##
==========================================
- Coverage   92.03%   92.03%   -0.01%     
==========================================
  Files         273      273              
  Lines       15455    15449       -6     
==========================================
- Hits        14224    14218       -6     
  Misses        849      849              
  Partials      382      382              
Impacted Files Coverage Δ
config/config.go 98.93% <ø> (-0.02%) ⬇️
component/componenttest/example_factories.go 87.96% <100.00%> (-0.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf6dc58...f03072b. Read the comment docs.

Copy link
Member

@tigrannajaryan tigrannajaryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any contrib components that still use deprecated CustomUnmarshaler or all are fixed now?

@bogdandrutu
Copy link
Member Author

@tigrannajaryan all are fixed and they are switched also to the helper "WithCustomUnmarshaler" from components helpers

@bogdandrutu bogdandrutu merged commit 68871bd into open-telemetry:main Mar 5, 2021
@bogdandrutu bogdandrutu deleted the rmdeprecatedunmarshaler branch March 5, 2021 22:03
This was referenced Mar 11, 2021
This was referenced Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants