Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Authentication processor - tech debt from the review #1824

Closed
jpkrohling opened this issue Sep 22, 2020 · 0 comments
Closed

Authentication processor - tech debt from the review #1824

jpkrohling opened this issue Sep 22, 2020 · 0 comments
Labels
area:processor enhancement New feature or request priority:p3 Lowest release:after-ga Stale

Comments

@jpkrohling
Copy link
Member

jpkrohling commented Sep 22, 2020 •
edited
Loading

During the review for the authentication processor PRs, the following items came up:

  1. We should consider renaming attribute to something else, possibly header, although future receivers might not be HTTP-based at all. Context: Authentication Helper 1/4 - Add configauth #1807 (comment)
  2. Move internal/auth to config/configauth/internal. Context: Authentication processor 2/4 - Add auth context and interface #1808 (comment)
@jpkrohling jpkrohling mentioned this issue Sep 22, 2020
Merged
@jpkrohling jpkrohling changed the title Rename attribute in auth conf settings Authentication processor - tech debt from the review Sep 24, 2020
@jpkrohling jpkrohling mentioned this issue Sep 24, 2020
Merged
@andrewhsu andrewhsu added enhancement New feature or request and removed feature request labels Jan 6, 2021
MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this issue Nov 11, 2021
@Aneurysm9
Update Default Value for Jaeger Exporter Endpoint (open-telemetry#1824)
e43d9c0 
* Update Default Value for OTEL_EXPORTER_JAEGER_ENDPOINT Env Var

* update comments

* fix documentation

* update CHANGELOG

* add missing tab

* fix lint issue

Co-authored-by: Anthony Mirabella <[email protected]>
@github-actions github-actions bot added the Stale label Jan 29, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 5, 2023
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this issue Apr 27, 2023
@dependabot @jeffreyc-splunk
Bump github.com/shirou/gopsutil/v3 from 3.22.6 to 3.22.7 in /tests (o…
b8b291c 
…pen-telemetry#1824)

* Bump github.com/shirou/gopsutil/v3 from 3.22.6 to 3.22.7 in /tests

Bumps [github.com/shirou/gopsutil/v3](https://github.com/shirou/gopsutil) from 3.22.6 to 3.22.7.
- [Release notes](https://github.com/shirou/gopsutil/releases)
- [Commits](shirou/gopsutil@v3.22.6...v3.22.7)

---
updated-dependencies:
- dependency-name: github.com/shirou/gopsutil/v3
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* go mod tidy

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: jeffreyc-splunk <[email protected]>
Troels51 pushed a commit to Troels51/opentelemetry-collector that referenced this issue Jul 5, 2024
@eguzki
Fix opentelemetry-proto file exists check (open-telemetry#1824)
82d8cb4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:processor enhancement New feature or request priority:p3 Lowest release:after-ga Stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jpkrohling @andrewhsu