Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary high memory in sharedcomponent #11818

Open
bogdandrutu opened this issue Dec 7, 2024 · 1 comment · May be fixed by #11826
Open

Unnecessary high memory in sharedcomponent #11818

bogdandrutu opened this issue Dec 7, 2024 · 1 comment · May be fixed by #11826
Assignees
Labels
area:componentstatus bug Something isn't working

Comments

@bogdandrutu
Copy link
Member

bogdandrutu commented Dec 7, 2024

The #10777 added the "capability" to keep all previously reported events in shared components and the list grows unbounded causing memory issues.

Proposed solution: only preserve the last reported event.

@bogdandrutu bogdandrutu added the bug Something isn't working label Dec 7, 2024
@TylerHelmuth
Copy link
Member

TylerHelmuth commented Dec 9, 2024

For a status aggregator I believe it is important that the previous events be played back in order. Since SharedComponent is internal and we control how it is used, and since we only ever add sources during startup, I suggest a circular buffer with a small size. This allows us to replay all the events during startup, but then during normal operation, once we are done adding sources, we won't have to remember every event we've ever sent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:componentstatus bug Something isn't working
Projects
None yet
2 participants