Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format generated test code #10899

Open
atoulme opened this issue Jan 11, 2024 · 7 comments
Open

Format generated test code #10899

atoulme opened this issue Jan 11, 2024 · 7 comments
Labels
cmd/mdatagen help wanted Good issue for contributors to OpenTelemetry Service to pick up

Comments

@atoulme
Copy link
Contributor

atoulme commented Jan 11, 2024

Component(s)

cmd/mdatagen

Describe the issue you're reporting

See open-telemetry/opentelemetry-collector-contrib#30425 (comment) and open-telemetry/opentelemetry-collector-contrib#30419 (comment)

Generated code is not formatted. We can run gofmt explicitly on the generated code when we generate the test.

Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@dmitryax
Copy link
Member

dmitryax commented Jan 11, 2024

My bigger concern is why linter isn't firing for this use case. Submitted open-telemetry/opentelemetry-collector-contrib#30439

@crobert-1
Copy link
Member

Sounds like a good idea to me, and the concern regarding the linter not running has been answered.

Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

@github-actions github-actions bot added the Stale label Mar 18, 2024
@dmitryax dmitryax added help wanted Good issue for contributors to OpenTelemetry Service to pick up and removed Stale labels Mar 18, 2024
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

@github-actions github-actions bot added the Stale label May 20, 2024
@crobert-1 crobert-1 removed the Stale label May 20, 2024
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

@github-actions github-actions bot added the Stale label Jul 22, 2024
@codeboten codeboten transferred this issue from open-telemetry/opentelemetry-collector-contrib Aug 16, 2024
@codeboten
Copy link
Contributor

transferred issue as mdatagen lives in the core repo now

@codeboten codeboten removed the Stale label Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmd/mdatagen help wanted Good issue for contributors to OpenTelemetry Service to pick up
Projects
None yet
Development

No branches or pull requests

4 participants