Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complete switch to new Collector metrics and avoid inadvertent changes #1082

Closed
2 of 4 tasks
pjanotti opened this issue Jun 4, 2020 · 2 comments · Fixed by #2105
Closed
2 of 4 tasks

Complete switch to new Collector metrics and avoid inadvertent changes #1082

pjanotti opened this issue Jun 4, 2020 · 2 comments · Fixed by #2105
Assignees
@pjanotti
Labels
enhancement New feature or request
Milestone
Backlog

Comments

@pjanotti
Copy link
Contributor

pjanotti commented Jun 4, 2020 •
edited by bogdandrutu
Loading

We should complete the switch from the Collector legacy metrics to the new Collector metrics and make harder for inadvertent changes affecting Collector metric names or labels.
@pjanotti pjanotti added the enhancement New feature or request label Jun 4, 2020
@pjanotti pjanotti self-assigned this Jun 4, 2020
@pjanotti pjanotti mentioned this issue Jun 4, 2020
Merged
@flands flands added this to the GA 1.0 milestone Jun 18, 2020
@pjanotti pjanotti mentioned this issue Jun 18, 2020
Merged
@nilebox
Copy link
Member

nilebox commented Jun 19, 2020 •
edited
Loading

Remove legacy metrics.

As described in #1148 (review), we need access to new metrics before deleting legacy metrics, to be able to reference them in our custom extensions.

I can submit a PR to unblock this, or you may make this change yourselves if you prefer.

@nilebox
Copy link
Member

nilebox commented Jun 20, 2020 •
edited
Loading

Alternatively, we may make the telemetry more customizable instead of just exposing its internal parts, e.g. add support for passing custom exporters and more granular configuration with explicit set of metrics to collect, i.e. make it a proper configurable pipeline.

I haven't thought about such design in detail yet, just an idea at this point.

@tigrannajaryan tigrannajaryan modified the milestones: GA 1.0, Backlog Oct 2, 2020
@bogdandrutu bogdandrutu mentioned this issue Nov 9, 2020
Merged
bogdandrutu added a commit to bogdandrutu/opentelemetry-collector that referenced this issue Nov 10, 2020
@bogdandrutu
Remove legacy metrics, they were marked as legacy for ~12 months
c5322b0 
Fixes open-telemetry#1082

This PR removes:
- Legacy receiver/exporter metrics:
  - otelcol/receiver/received_spans
  - otelcol/receiver/dropped_spans
  - otelcol/receiver/received_timeseries
  - otelcol/receiver/dropped_timeseries
  - otelcol/exporter/received_spans
  - otelcol/exporter/dropped_spans
  - otelcol/exporter/received_timeseries
  - otelcol/exporter/dropped_timeseries
  - otelcol/exporter/received_logs
  - otelcol/exporter/dropped_logs
- For processors remove the legacy metrics (new metrics have the same data, different names):
  - e.g. "spans_dropped" -> "processor/spans_dropped"
  - e.g. "batch_send_size_bytes" -> "processor/batch/batch_send_size_bytes"

All the new metrics were enabled when using the --new-metrics flag. The PR also removes two flags:
- "--new-metrics"
- "--legacy-metrics"
Signed-off-by: Bogdan Drutu <[email protected]>
bogdandrutu added a commit to bogdandrutu/opentelemetry-collector that referenced this issue Nov 10, 2020
@bogdandrutu
Remove legacy metrics, they were marked as legacy for ~12 months
f7bbb4f 
Fixes open-telemetry#1082

This PR removes:
- Legacy receiver/exporter metrics:
  - otelcol/receiver/received_spans
  - otelcol/receiver/dropped_spans
  - otelcol/receiver/received_timeseries
  - otelcol/receiver/dropped_timeseries
  - otelcol/exporter/received_spans
  - otelcol/exporter/dropped_spans
  - otelcol/exporter/received_timeseries
  - otelcol/exporter/dropped_timeseries
  - otelcol/exporter/received_logs
  - otelcol/exporter/dropped_logs
- For processors remove the legacy metrics (new metrics have the same data, different names):
  - e.g. "spans_dropped" -> "processor/spans_dropped"
  - e.g. "batch_send_size_bytes" -> "processor/batch/batch_send_size_bytes"

All the new metrics were enabled when using the --new-metrics flag. The PR also removes two flags:
- "--new-metrics"
- "--legacy-metrics"
Signed-off-by: Bogdan Drutu <[email protected]>
@bogdandrutu bogdandrutu mentioned this issue Nov 10, 2020
Merged
bogdandrutu added a commit to bogdandrutu/opentelemetry-collector that referenced this issue Nov 10, 2020
@bogdandrutu
Remove legacy metrics, they were marked as legacy for ~12 months
f3111d4 
Fixes open-telemetry#1082

This PR removes:
- Legacy receiver/exporter metrics:
  - otelcol/receiver/received_spans
  - otelcol/receiver/dropped_spans
  - otelcol/receiver/received_timeseries
  - otelcol/receiver/dropped_timeseries
  - otelcol/exporter/received_spans
  - otelcol/exporter/dropped_spans
  - otelcol/exporter/received_timeseries
  - otelcol/exporter/dropped_timeseries
  - otelcol/exporter/received_logs
  - otelcol/exporter/dropped_logs
- For processors remove the legacy metrics (new metrics have the same data, different names):
  - e.g. "spans_dropped" -> "processor/spans_dropped"
  - e.g. "batch_send_size_bytes" -> "processor/batch/batch_send_size_bytes"

All the new metrics were enabled when using the --new-metrics flag. The PR also removes two flags:
- "--new-metrics"
- "--legacy-metrics"
Signed-off-by: Bogdan Drutu <[email protected]>
bogdandrutu added a commit that referenced this issue Nov 10, 2020
@bogdandrutu
Remove legacy metrics, they were marked as legacy for ~12 months (#2105)
d322a41 
* Remove legacy metrics, they were marked as legacy for ~12 months

Fixes #1082

This PR removes:
- Legacy receiver/exporter metrics:
  - otelcol/receiver/received_spans
  - otelcol/receiver/dropped_spans
  - otelcol/receiver/received_timeseries
  - otelcol/receiver/dropped_timeseries
  - otelcol/exporter/received_spans
  - otelcol/exporter/dropped_spans
  - otelcol/exporter/received_timeseries
  - otelcol/exporter/dropped_timeseries
  - otelcol/exporter/received_logs
  - otelcol/exporter/dropped_logs
- For processors remove the legacy metrics (new metrics have the same data, different names):
  - e.g. "spans_dropped" -> "processor/spans_dropped"
  - e.g. "batch_send_size_bytes" -> "processor/batch/batch_send_size_bytes"

All the new metrics were enabled when using the --new-metrics flag. The PR also removes two flags:
- "--new-metrics"
- "--legacy-metrics"
Signed-off-by: Bogdan Drutu <[email protected]>

* Update changelog

Signed-off-by: Bogdan Drutu <[email protected]>

* Fix comments from review

Signed-off-by: Bogdan Drutu <[email protected]>
punya pushed a commit to punya/opentelemetry-collector-contrib that referenced this issue Jul 21, 2021
@bogdandrutu
Remove legacy metrics, they were marked as legacy for ~12 months (#2105)
1c09cd5 
* Remove legacy metrics, they were marked as legacy for ~12 months

Fixes open-telemetry/opentelemetry-collector#1082

This PR removes:
- Legacy receiver/exporter metrics:
  - otelcol/receiver/received_spans
  - otelcol/receiver/dropped_spans
  - otelcol/receiver/received_timeseries
  - otelcol/receiver/dropped_timeseries
  - otelcol/exporter/received_spans
  - otelcol/exporter/dropped_spans
  - otelcol/exporter/received_timeseries
  - otelcol/exporter/dropped_timeseries
  - otelcol/exporter/received_logs
  - otelcol/exporter/dropped_logs
- For processors remove the legacy metrics (new metrics have the same data, different names):
  - e.g. "spans_dropped" -> "processor/spans_dropped"
  - e.g. "batch_send_size_bytes" -> "processor/batch/batch_send_size_bytes"

All the new metrics were enabled when using the --new-metrics flag. The PR also removes two flags:
- "--new-metrics"
- "--legacy-metrics"
Signed-off-by: Bogdan Drutu <[email protected]>

* Update changelog

Signed-off-by: Bogdan Drutu <[email protected]>

* Fix comments from review

Signed-off-by: Bogdan Drutu <[email protected]>
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this issue Apr 27, 2023
@dependabot
Bump boto3 in /internal/buildscripts/packaging/release (open-telemetr…
4bf03f6 
…y#1082)

Bumps [boto3](https://github.com/boto/boto3) from 1.20.28 to 1.20.29.
- [Release notes](https://github.com/boto/boto3/releases)
- [Changelog](https://github.com/boto/boto3/blob/develop/CHANGELOG.rst)
- [Commits](boto/boto3@1.20.28...1.20.29)

---
updated-dependencies:
- dependency-name: boto3
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Troels51 pushed a commit to Troels51/opentelemetry-collector that referenced this issue Jul 5, 2024
@owent
Fix open-telemetry#1081 (open-telemetry#1082)
caade51
swiatekm pushed a commit to swiatekm/opentelemetry-collector that referenced this issue Oct 9, 2024
@julianocosta89 @puckpuck @TylerHelmuth
[demo] Remove FeatureFlagService and add flagd (open-telemetry#1082)
5009834 
* Remove FeatureFlagService and add flagd

* Override image name

* Update Grafana OpenSearch datasource version

* Update Grafana OpenSearch datasource

* fix flagd service

Signed-off-by: Pierre Tessier <[email protected]>

* fix flagd service

Signed-off-by: Pierre Tessier <[email protected]>

* fix flagd service

Signed-off-by: Pierre Tessier <[email protected]>

* fix flagd service

Signed-off-by: Pierre Tessier <[email protected]>

* Update chart with latest release

* Update shippingservice env var

* Remove feature flag service from notes

Signed-off-by: Pierre Tessier <[email protected]>

* Use demo.flagd.json from demo repo

Signed-off-by: Pierre Tessier <[email protected]>

---------

Signed-off-by: Pierre Tessier <[email protected]>
Co-authored-by: Pierre Tessier <[email protected]>
Co-authored-by: Tyler Helmuth <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pjanotti pjanotti

Labels
enhancement New feature or request
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Remove legacy metrics, they were marked as legacy for ~12 months bogdandrutu/opentelemetry-collector
4 participants
@flands @tigrannajaryan @pjanotti @nilebox